Platonides [Tue, 19 Jul 2011 19:05:23 +0000 (19:05 +0000)]
Profiling errors. r92106 missed a wfProfileOut
r92118 added a wfProfileIn but not all returns were covered. Also changed its spaces to tabs.
Platonides [Tue, 19 Jul 2011 19:00:09 +0000 (19:00 +0000)]
Follow up to r91561: Use the canonical class names.
Robin Pepermans [Tue, 19 Jul 2011 15:52:38 +0000 (15:52 +0000)]
Follow-up r92528:
* remove @static
* return database result directly (no need for while())
* getAllPrefixesDb() -> getAllPrefixesDB()
Robin Pepermans [Tue, 19 Jul 2011 13:30:38 +0000 (13:30 +0000)]
Follow-up r92528: probably better to put it in the API & new features sections
Robin Pepermans [Tue, 19 Jul 2011 12:30:18 +0000 (12:30 +0000)]
(bug 19838) API does not use interwiki cache.
Patch by Beau; modified to work with current code.
Russ Nelson [Tue, 19 Jul 2011 03:44:28 +0000 (03:44 +0000)]
mark a non-API function private; rename it to reflect what it does; call getPath() rather than accessing object variable directly
Jeroen De Dauw [Tue, 19 Jul 2011 00:43:20 +0000 (00:43 +0000)]
style fix
Ian Baker [Mon, 18 Jul 2011 23:23:14 +0000 (23:23 +0000)]
Refactored section assembly code to be more readable
Added a hook that's called for each section. This allows sections to be addressed separately at the document level, for example by wrapping each in a div (as in the reverted r50769). This in-turn enables richer section-specific UI, like highlighting or in-line editing.
Sam Reed [Mon, 18 Jul 2011 23:04:09 +0000 (23:04 +0000)]
Revert 2 from r92498
Sam Reed [Mon, 18 Jul 2011 23:01:08 +0000 (23:01 +0000)]
Update code comments that point to 1.18 to point to 1.19
Sam Reed [Mon, 18 Jul 2011 22:53:52 +0000 (22:53 +0000)]
Add RELEASE-NOTES-1.18.old into RELEASE-NOTES-1.18
Needs svn copy in REL1_18
Aaron Schulz [Mon, 18 Jul 2011 22:30:38 +0000 (22:30 +0000)]
Removed testBug29116LoadWithEmptyIp. Fails due to wfDeprecated() call in load() and nothing uses that so it's not worth it.
Sam Reed [Mon, 18 Jul 2011 22:27:25 +0000 (22:27 +0000)]
Move current RELEASE-NOTES-1.18 to RELEASE-NOTES-1.18.old
Moved RELEASE-NOTES-1.19 to RELEASE-NOTES-1.18
Wipe RELEASE-NOTES-1.19
Updating text where necessary
Keeping RELEASE-NOTES-1.18.old till we've established there's nothing that just went into that changelog
Sam Reed [Mon, 18 Jul 2011 22:23:42 +0000 (22:23 +0000)]
Add comment
Remove unused wfGetDb()
Andrew Garrett [Mon, 18 Jul 2011 22:02:11 +0000 (22:02 +0000)]
Fix autoblocks in r92480 r92482 -- modified the wrong half
Sam Reed [Mon, 18 Jul 2011 22:01:40 +0000 (22:01 +0000)]
It seems people don't either pay attention to code comments, or those comments lie
r92461
Andrew Garrett [Mon, 18 Jul 2011 21:56:59 +0000 (21:56 +0000)]
Fix autoblocks in r92480
Chad Horohoe [Mon, 18 Jul 2011 21:56:10 +0000 (21:56 +0000)]
(bug 29959) Installer fatal when cURL and allow_url_fopen is disabled and user tries to subsribe to mediawiki-announce
Really, I'm not sure about the usefulness of exploding with a MWException anytime we can't do an external request, but at least we can stop the installer from exploding :)
Andrew Garrett [Mon, 18 Jul 2011 21:48:56 +0000 (21:48 +0000)]
Block.php fixes: Always store mExpiry as a TS_MW or "infinity". Convert as appropriate.
Sam Reed [Mon, 18 Jul 2011 21:26:33 +0000 (21:26 +0000)]
* (bug 29938) list=users&usprop=rights shows rights the user doesn't have
Alexandre Emsenhuber [Mon, 18 Jul 2011 20:52:22 +0000 (20:52 +0000)]
Let Skin extend ContextSource instead of reinventing the wheel
Aaron Schulz [Mon, 18 Jul 2011 20:44:51 +0000 (20:44 +0000)]
Refactored new getAutomaticGroups() function out of getEffectiveGroups()
Sam Reed [Mon, 18 Jul 2011 20:11:53 +0000 (20:11 +0000)]
Documentation updates
Add a couple of missing explicit class variables
Raimond Spekking [Mon, 18 Jul 2011 20:05:52 +0000 (20:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-18 19:50:00 UTC)
Sam Reed [Mon, 18 Jul 2011 19:56:16 +0000 (19:56 +0000)]
Set explicit public modifier
Swap @private to private
Ian Baker [Mon, 18 Jul 2011 19:31:38 +0000 (19:31 +0000)]
changed sessionkey to filekey to keep consistent with the rest of UploadStash (while retaining sessionkey for backwards compatibility)
Neil Kandalgaonkar [Mon, 18 Jul 2011 18:59:56 +0000 (18:59 +0000)]
removing xdebug call
Mark A. Hershberger [Mon, 18 Jul 2011 18:05:45 +0000 (18:05 +0000)]
Bug #29874 - Image extension strict whitelist handling is inconsistent
Patch from Dan Collins
Aaron Schulz [Mon, 18 Jul 2011 17:23:56 +0000 (17:23 +0000)]
Updated doMaintenance since wmf-config/ was moved up a dir
Sam Reed [Mon, 18 Jul 2011 16:09:50 +0000 (16:09 +0000)]
Remove call to User::getImplicitGroups() from ApiQueryAllUsers
Per the below, as User::getGroupsWithPermission() will return */autoconfirmed, etc if applicable
> var_dump( User::getGroupsWithPermission( 'createtalk' ) );
array(2) {
[0]=>
string(1) "*"
[1]=>
string(4) "user"
}
> var_dump( User::getGroupsWithPermission( 'autoconfirmed' ) );
array(5) {
[0]=>
string(13) "autoconfirmed"
[1]=>
string(3) "bot"
[2]=>
string(5) "sysop"
[3]=>
string(8) "reviewer"
[4]=>
string(9) "confirmed"
}
Alexandre Emsenhuber [Mon, 18 Jul 2011 15:41:09 +0000 (15:41 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
* Use Linker::linkKnown() instead of Linker::link() where possible
Sam Reed [Mon, 18 Jul 2011 13:19:46 +0000 (13:19 +0000)]
* (bug 29935) Improve formatting of examples in ApiParamInfo
Old example string with newlines left for the moment, pending discussion on bug...
Sam Reed [Mon, 18 Jul 2011 13:14:05 +0000 (13:14 +0000)]
Kill unused globals
Remove unreachable return;
Sam Reed [Mon, 18 Jul 2011 13:10:29 +0000 (13:10 +0000)]
-rakkaus/#mediawiki-i18n- (1 lines skipped) [18-Jul-2011 12:54:37] PHP Fatal error: Call to a member function addHTML() on a non-object in /www/w/includes/specials/SpecialWatchlist.php on line 65
Swap $out for $output
Aaron Schulz [Mon, 18 Jul 2011 03:30:03 +0000 (03:30 +0000)]
Disallow given options twice (instead of letting the newest one take precedence). This property may be useful for a Het Deploy wrapper.
Robin Pepermans [Sun, 17 Jul 2011 23:18:06 +0000 (23:18 +0000)]
Fix r92418: 'fr', of course
Robin Pepermans [Sun, 17 Jul 2011 23:16:56 +0000 (23:16 +0000)]
Add fallback 'frc' -> 'fr'. Main translator agreed ( translatewiki.net/wiki/Thread:User_talk:Ebe123/Fallback_for_'frc' ).
Raimond Spekking [Sun, 17 Jul 2011 19:50:15 +0000 (19:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-17 19:25:00 UTC)
Sam Reed [Sun, 17 Jul 2011 17:23:51 +0000 (17:23 +0000)]
Add a couple more useful URL's to the API help banner
Add help url for ApiQueryDeletedrevs
Sam Reed [Sun, 17 Jul 2011 17:09:51 +0000 (17:09 +0000)]
Followup r92396
Using action=paraminfo to give help urls (and examples for that matter!!) look awful as a string with an encoded \n in the middle of it
Sam Reed [Sun, 17 Jul 2011 17:02:06 +0000 (17:02 +0000)]
* (bug 28817) Add reference help page link to API Modules
Last followup of r92396
Should be all modules with documentation pages in core now documented...
Sam Reed [Sun, 17 Jul 2011 16:51:11 +0000 (16:51 +0000)]
Followup r92396
More modules documented, pretty much only action=query&list= to be done (ie links added where documentation pages exist already)
Sam Reed [Sun, 17 Jul 2011 16:38:24 +0000 (16:38 +0000)]
Followup r92396, add help urls for most of the core (non query) modules
Sam Reed [Sun, 17 Jul 2011 16:23:29 +0000 (16:23 +0000)]
Followup r92396 rename method, fix boolean comparison that was supposed to be inverted when de-indenting
Sam Reed [Sun, 17 Jul 2011 16:18:09 +0000 (16:18 +0000)]
* (bug 28817) Add reference help page link to API Modules
Start of this bug, fleshed out base code implemented, plus a few key modules (will finish rest up soon)
Tweaked/improved/updated some documentation as I went through also
Sam Reed [Sun, 17 Jul 2011 15:48:51 +0000 (15:48 +0000)]
Flesh out some TODO documentation from onwiki pages
Alexandre Emsenhuber [Sun, 17 Jul 2011 09:33:34 +0000 (09:33 +0000)]
Fix for r92388: that was the wrong method
Alexandre Emsenhuber [Sun, 17 Jul 2011 09:25:50 +0000 (09:25 +0000)]
* Changed Special:RecentChanges and Special:RecentChangesLinked to use the local context instead of global variables
* Added context to ChangesList
* Added new factory for ChangesList and subclasses in ChangesList::newFromContext() and modified ChangesList::newFromUser() to call it with the main context since anyway User::getSkin() return the Skin from the main context, so this won't change anything but the User::getOption() call
* Updates Special:RecentChanges and Special:Watchlist to use that new function
* Call Linker methods statically
* Use Linker::linkKnown() instead of Linker::link() where possible
* In Special:Watchlist: Use wfMessage() instead of OutputPage::addWikiMsgArray() with the third parameter
Alexandre Emsenhuber [Sun, 17 Jul 2011 07:47:13 +0000 (07:47 +0000)]
* Expanded documentation, added GPL header and changed the @author tag to use my real name
* Made RequestContext implement IContextSource
* Added ContextSource::msg()
* Made ContextSource fall back to RequestContext::getMain() when there's no context set
Raimond Spekking [Sat, 16 Jul 2011 20:06:00 +0000 (20:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-16 19:52:00 UTC)
Ping r92057: Full export of core and ext-installer
Alexandre Emsenhuber [Sat, 16 Jul 2011 19:31:18 +0000 (19:31 +0000)]
* Use standard method to check user permissions
* Directly throw an ReadOnlyError instead of calling OutputPage::readOnlyPage()
* In Special:Block: don't let user think the error is temporary if he doesn't have right and the database is locked, instead check permissions first and then the database lock
Alexandre Emsenhuber [Sat, 16 Jul 2011 19:19:01 +0000 (19:19 +0000)]
* Use wfMessage() instead of OutputPage::addWikiMsgArray() with the third parameter
* In EditPage.php: call Linker methods statically
Bryan Tong Minh [Sat, 16 Jul 2011 16:09:00 +0000 (16:09 +0000)]
First steps for bug 14801: add backend support for per-namespace permissions to core. This extends $wgGroupPermissions syntax from $wgGroupPermissions[$group][$right] = bool to $wgGroupPermissions[$group][$right] = array( NS_X => bool ). This is safely backwards compatible; the booleans are still fully supported, and any unset namespace will default to false.
* User::getRights(), User::isAllowed() and User::getGroupPermissions now optionally accept a namespace parameter. If not set, it will check whether the user has the right for all namespaces.
* Anything that uses Title::getUserPermissionsErrorsInternal() automatically supports per-namespace permissions. This includes Title::getUserPermissionsErrors and Title::(quick)UserCan.
* Fix tests that set User::mRights
The next step would be to change all User::isAllowed() to Title::quickUserCan or pass the namespace to User::isAllowed().
Alexandre Emsenhuber [Sat, 16 Jul 2011 13:36:37 +0000 (13:36 +0000)]
* Use local context instead of global variables
* Call Linker methods statically
* Changed some messages to replace parameters before parsing where possible
* Changed usage of OutputPage::addWikiMsgArray() with third parameter to wfMessage()
Niklas Laxström [Sat, 16 Jul 2011 11:40:28 +0000 (11:40 +0000)]
Array indexes start from zero
Robin Pepermans [Sat, 16 Jul 2011 00:14:33 +0000 (00:14 +0000)]
Remove 'dk' from dummy language codes, it was removed in r71693.
Robin Pepermans [Fri, 15 Jul 2011 23:28:30 +0000 (23:28 +0000)]
Split MessagesKs into ks-arab and ks-deva, as Kashmiri is written in two scripts. The MessagesKs file contained rtl = true, which is only for the Arab script, and the digit transform table which was for the Devanagari script.
Added one lonely message from kswiki.
Also specified comment of Quechua to Southern Quechua, as it is the variety used in MessagesQu and on quwiki.
Sam Reed [Fri, 15 Jul 2011 23:18:38 +0000 (23:18 +0000)]
sync up RELEASE-NOTES
Krinkle [Fri, 15 Jul 2011 22:57:57 +0000 (22:57 +0000)]
html:key should be self-closing in jquery.localize unit tests.
More IE6, 7 and 8 fixes for jquery.localize unit tests.
html:key should be self-closing. This was in most tests, but accidentally forgotten in a few. Other browsers are looser on this, but IE is very strict about it.
Krinkle [Fri, 15 Jul 2011 22:54:28 +0000 (22:54 +0000)]
Removing deprecated <msg /> support in jquery.localize. Maintaing it is a PITA and it doesn't work properly in IE6, 7 and 8.
<html:msg /> has been the new format for a while.
Krinkle [Fri, 15 Jul 2011 22:43:32 +0000 (22:43 +0000)]
Increasing timeout duration. Some TestSwarm participants appear to have slower virtual machines and/or may have network slowness. 1.5 second was a bit too short anyway. This will reduce false positives.
Alexandre Emsenhuber [Fri, 15 Jul 2011 20:56:46 +0000 (20:56 +0000)]
* Use local context instead of global variables
* Call Linker methods satically
* Use wfMessage() instead of OutputPage::addWikiMsgArray() with a third parameter
Aaron Schulz [Fri, 15 Jul 2011 20:47:37 +0000 (20:47 +0000)]
Removed unused function
Leo Koppelkamm [Fri, 15 Jul 2011 20:24:00 +0000 (20:24 +0000)]
r92288 : Missed second arg to inArray
Krinkle [Fri, 15 Jul 2011 19:25:16 +0000 (19:25 +0000)]
ajaxCategories fixes:
* Partial revert of r92264. mw.ajaxCategories has nothing to do with mediawiki.util.init, moved into separate initiation module, only loaded when ajax categories is enabled.
* Removing instantiation from the script. mw.ajaxCategories is now a public accessible constructor
* Fix Uncaught ReferenceError: wgUserGroups is not defined
($wgLegacyJavaScriptGlobals = false;)
* Renamimng stripIllegals() to clean(), adding '#' to the regex as those are not allowed either.
* Combining var statements by separating them with comma's ( var foo, bar, baz; ) instead of "var foo; var bar; var baz;"svn up
* Using dot.notation for objects instead of array-like['string'] keys
* Whitespace conventions
* Using inArray utility instead of indexOf (cross-browser support, mostly IE6)
** $.inArray uses Array.prototype.indexOf if available, otherwise fallback to a loop. mw.util.inArray is a wrapper around $.inArray to return a boolean value (since inArray/indexOf may return 0)
* Don't use $( '#bodyContent' ) (skin specific) but mw.util.$content
* Using mw.Title
* Re-using helper functions from the outer-closure instead of re-declaring them privately for every instance again (performance!)
Follows-up: r92112, r92151, r92264
Bryan Tong Minh [Fri, 15 Jul 2011 19:11:24 +0000 (19:11 +0000)]
RELEASE-NOTES for r92279
Bryan Tong Minh [Fri, 15 Jul 2011 19:03:40 +0000 (19:03 +0000)]
(bug 28762) Resizing to specified height broken for very thin images
Restructure and comment of ImageHandler::normaliseParams(). ImageHandler::normaliseParams() will now output both width/height as physicalWidth/Height, where width/height are the dimensions used by the browser, and physicalWidth/Height are the dimensions of the thumbnail that will be created. This allows keeping the use of unique dimensions for a specified thumbnail width, by forcing client side resizing of 1px-wide images with non corresponding height.
Also fixed a bug where the check for mustRender() was in an if statement where it should not have been.
Leo Koppelkamm [Fri, 15 Jul 2011 18:34:09 +0000 (18:34 +0000)]
Fix r92253
Ian Baker [Fri, 15 Jul 2011 18:33:31 +0000 (18:33 +0000)]
No longer using the content hash as a file key. This solves a concurrency problem when multiple people use the same account to upload from the same set of files. Each stashed file is now a unique and beautiful snowflake, and the content-based deduping that comes at the end of the process can sort it out.
Roan Kattouw [Fri, 15 Jul 2011 18:27:27 +0000 (18:27 +0000)]
Fix typo in r91154
Leo Koppelkamm [Fri, 15 Jul 2011 18:21:37 +0000 (18:21 +0000)]
AjaxCategories: Making MultiEdit mores stable and getting rid of other bugs
Leo Koppelkamm [Fri, 15 Jul 2011 18:19:10 +0000 (18:19 +0000)]
r92253 : readd useful changes
Krinkle [Fri, 15 Jul 2011 18:10:38 +0000 (18:10 +0000)]
Add boolean inArray utility
Ryan Kaldari [Fri, 15 Jul 2011 17:54:50 +0000 (17:54 +0000)]
better method descriptions
Brion Vibber [Fri, 15 Jul 2011 17:34:39 +0000 (17:34 +0000)]
followup r92253: revert accidental commit of test code
Brion Vibber [Fri, 15 Jul 2011 17:29:17 +0000 (17:29 +0000)]
Revert r92238: partial addition of broken test cases to qunit test suite; loading of modules with uninitialized data triggers errors in console and marks the entire revision black in TestSwarm.
Bryan Tong Minh [Fri, 15 Jul 2011 17:13:24 +0000 (17:13 +0000)]
Add words.txt for us Windows users. This is a random selection of 1000 words from gnuwin32 miscfiles package
Fail more gracefully in RandomImageGenerator
Chad Horohoe [Fri, 15 Jul 2011 16:59:38 +0000 (16:59 +0000)]
Slightly more informative error message when passed a bogus key (rather than property of non-object)
Chad Horohoe [Fri, 15 Jul 2011 15:54:14 +0000 (15:54 +0000)]
Stylize
Bryan Tong Minh [Fri, 15 Jul 2011 15:13:18 +0000 (15:13 +0000)]
Follow-up r79845: Fix rotation. Turns out that we need to pass the pre-rotation dimensions to convert.exe. Also added tests.
Leo Koppelkamm [Fri, 15 Jul 2011 15:06:58 +0000 (15:06 +0000)]
r92054 : Fix wordwrap by using inline-block. This has the nice sideeffect of fixing an Opera background image bug as well. Remove categories from print, they're not especially useful on paper. (Also give footer some space)
Alexandre Emsenhuber [Fri, 15 Jul 2011 14:28:24 +0000 (14:28 +0000)]
Per Nikerabbit, follow-up to r92231: removed unreachable code
Jure Kajzer [Fri, 15 Jul 2011 12:44:31 +0000 (12:44 +0000)]
* maintenance script to switch FK references if using wgSharedDB
Leo Koppelkamm [Fri, 15 Jul 2011 11:12:07 +0000 (11:12 +0000)]
AjaxCategories: move self init to mw.util.init; start with qunit
Antoine Musso [Fri, 15 Jul 2011 09:45:57 +0000 (09:45 +0000)]
NS_MAIN can locally have subpages enabled
This workaround test if any local change has been made, if so the test
will be skipped.
fu r82577
Alexandre Emsenhuber [Fri, 15 Jul 2011 08:42:25 +0000 (08:42 +0000)]
* Use local context instead of global variables
* Removed parameters that could be replaced by context
* Call Linker methods statically
* Removed two unused methods: countWatchlist() and showItemCount()
* The parameter of SpecialEditWatch::buildTools() is now unused
Chad Horohoe [Fri, 15 Jul 2011 05:32:57 +0000 (05:32 +0000)]
Fix for r92187
Roan Kattouw [Fri, 15 Jul 2011 02:21:52 +0000 (02:21 +0000)]
Followup r91672: remove commented-out reference to removed file (rtl.css)
Aaron Schulz [Fri, 15 Jul 2011 00:48:02 +0000 (00:48 +0000)]
Follow-up r92220: changed autoblock handling to use PerformRetroactiveAutoblock hook instead of a global. Also made CheckUser always override autoblocks (no config).
Aaron Schulz [Fri, 15 Jul 2011 00:05:50 +0000 (00:05 +0000)]
* Removed angry autoblock code - unused by anything
* Added $wgAutoblockHandlers variable for alternative autoblock handling functions
* Gave CheckUser a potential $wgAutoblockHandlers function (bug 29330)
Ian Baker [Thu, 14 Jul 2011 23:01:00 +0000 (23:01 +0000)]
properly handle the case where a file disappears during the uploadwizard process
remove database records for files that move out of the stash
Ian Baker [Thu, 14 Jul 2011 21:33:09 +0000 (21:33 +0000)]
fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible.
Leo Koppelkamm [Thu, 14 Jul 2011 20:48:01 +0000 (20:48 +0000)]
AjaxCategories: More interface polish
Chad Horohoe [Thu, 14 Jul 2011 20:38:28 +0000 (20:38 +0000)]
Kill AjaxFunctions.php. The only thing using this was FCKEditor, so I moved js_unescape() over to it.
Roan: "So what does it do?"
Me: "Converts stuff encoded with JS's escape() back into a normal string, according to the docs."
Roan: "That sounds like a workaround for bad design"
Chad Horohoe [Thu, 14 Jul 2011 20:19:59 +0000 (20:19 +0000)]
Various cleanups to ExternalEdit. Documentation, code style, removed some unused variables, removed silly 'm' prefix, etc.
Raimond Spekking [Thu, 14 Jul 2011 20:12:43 +0000 (20:12 +0000)]
Localisation updates for core and extension messages from translatewiki.net (2011-07-14 19:36:00 UTC)
Ping r92057: Full export of core and ext-installer
Chad Horohoe [Thu, 14 Jul 2011 17:48:41 +0000 (17:48 +0000)]
Use the context's response for header() calls in checkMaxLag()
Aaron Schulz [Thu, 14 Jul 2011 17:39:04 +0000 (17:39 +0000)]
Made WikiPage::factory a bit more dummy proof
Leo Koppelkamm [Thu, 14 Jul 2011 17:26:32 +0000 (17:26 +0000)]
Fix expandableField.js dependencies
Leo Koppelkamm [Thu, 14 Jul 2011 17:14:39 +0000 (17:14 +0000)]
AjaxCategories: Add basic hook functionality. Can be used by sites for stuff like {{uncategorized}} templates etc.